Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen.site): multiple routers prompt #783

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

leandrocp
Copy link
Contributor

No description provided.

@tomciopp
Copy link

This should probably use Keyword.get/3 instead of an || condition.

@leandrocp
Copy link
Contributor Author

Keyword.get/3 has a small flaw that still permits nil values:

iex> Keyword.get([label: nil], :label, "default")
nil

iex> Keyword.get([label: nil], :label) || "default"
"default"

We want the later :)

@leandrocp leandrocp merged commit 48a9f30 into main Feb 26, 2025
3 checks passed
@leandrocp leandrocp deleted the lp-fix-select-router branch February 26, 2025 22:52
@leandrocp
Copy link
Contributor Author

@tomciopp do you mind giving it a try?

{:beacon, github: "BeaconCMS/beacon", override: true}

If that works as expected and no other bugs are found we can release a patch version

@tomciopp
Copy link

@leandrocp Everything looks good with those changes!

@leandrocp
Copy link
Contributor Author

@tomciopp v0.4.2 just released, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants